Skip to content

chore: add release contributors section#1690

Open
AkashKumar7902 wants to merge 1 commit intokubewarden:mainfrom
AkashKumar7902:issue-831-release-contributors
Open

chore: add release contributors section#1690
AkashKumar7902 wants to merge 1 commit intokubewarden:mainfrom
AkashKumar7902:issue-831-release-contributors

Conversation

@AkashKumar7902
Copy link
Copy Markdown

Summary

  • Add a Contributors section to the Release Drafter template using $CONTRIBUTORS.
  • Keep the existing release categories, labels, and version resolver unchanged.

Fixes #831

Validation

  • yq '.' .github/release-drafter.yml
  • yq -e '.template == "$CHANGES\n\n## Contributors\n\n$CONTRIBUTORS\n"' .github/release-drafter.yml
  • git diff --check

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Contributors section to this repository’s Release Drafter-generated release notes to satisfy issue #831’s requirement that GitHub Releases include the list of people who contributed to the release.

Changes:

  • Update Release Drafter template to append a “## Contributors” section.
  • Populate that section using Release Drafter’s $CONTRIBUTORS placeholder.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jvanz
Copy link
Copy Markdown
Member

jvanz commented Apr 28, 2026

@AkashKumar7902 you need to fix the commit signature to allow us to merge this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.43%. Comparing base (88b4b9c) to head (36cfb0f).
⚠️ Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
+ Coverage   75.53%   80.43%   +4.90%     
==========================================
  Files         170      127      -43     
  Lines       20900    16413    -4487     
==========================================
- Hits        15786    13202    -2584     
+ Misses       4902     3211    -1691     
+ Partials      212        0     -212     
Flag Coverage Δ
go-tests ?
rust-tests 80.43% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jvanz jvanz moved this from Pending review to Blocked in Kubewarden Admission Controller Apr 28, 2026
@AkashKumar7902
Copy link
Copy Markdown
Author

I checked this one. The current head commit is unsigned, and the local SSH key available in this environment is not registered as a GitHub signing key. I also tried to add it as a signing key, but the current gh token does not have admin:ssh_signing_key, so GitHub rejects that API call.

I am not force-pushing a locally signed unknown_key commit because that would still fail the verified-signature requirement. This needs either re-signing with a key already registered in GitHub as a signing key, or registering the available key first and then re-signing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Release drafter: add list of contributors to the release description

4 participants